fix(test): correct async context manager mocking for bedrock routing#253
Merged
Conversation
zxqfd555
approved these changes
Jun 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
This PR resolves a persistent CI failure (
AttributeError: __aenter__) in thetest_bedrock_dynamic_args_routingtest suite.The test previously mocked the Bedrock client session using standard
AsyncMockbehavior, which can be unstable when resolving async context managers across different Python/Pytest environments. Because theBedrockChatproduction code evaluatesasync with self._session.client("bedrock-runtime") as client:, the mocked client must implement strict asynchronous context manager protocols. This PR explicitly constructs and injects a deterministic async context manager (__aenter__and__aexit__) to guarantee stable test execution.How has this been tested?
python/pathway/xpacks/llm/tests/test_llms.pyto confirm the manualMagicMockcorrectly satisfies theasync withcontext evaluation without raisingAttributeErrorexceptions.blackandflake8.Types of changes
Related issue(s):
Checklist: